[New-Viz][AmericanExpress] Funnel/Step Visualization

[TheLastSultan]

CATEGORY

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

This is a PR to our most popular viz_type at American Express. The Step/Funnel Visualization is a 2 in 1 visualization that is simple to use and highly modifiable. It has unique support of multi-pass queries and thus is worthy of the PR effort. The 'Funnel' feature can be turned on or off if the user prefers a simple step visualization over 'funnel'.

Funnel-Mode

Step-Mode

Control Panel Supports Multi-Step Queries with 'Add Step'

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

[villebro]

Would you be able to post some screenshots? I think step charts would be an awesome addition, as they seem to be all the rage for decomposing financials these days.

[etr2460]

Linking this comment here: #8346 (comment)

Maybe this should be in a separate plugin instead so that we don't update the deprecated viz.py file

[codecov-io]

Codecov Report

Merging #8358 into master will decrease coverage by 0.57%.
The diff coverage is 21.63%.

@@            Coverage Diff             @@
##           master    #8358      +/-   ##
==========================================
- Coverage   67.46%   66.88%   -0.58%     
==========================================
  Files         448      455       +7     
  Lines       22527    22869     +342     
  Branches     2364     2424      +60     
==========================================
+ Hits        15197    15296      +99     
- Misses       7192     7435     +243     
  Partials      138      138

Impacted Files	Coverage Δ
...et/assets/src/explore/components/controls/index.js	100% <ø> (ø)	⬆️
...et/assets/src/visualizations/presets/MainPreset.js	0% <ø> (ø)	⬆️
...perset/assets/src/visualizations/Funnel/Funnel.jsx	0% <0%> (ø)
superset/assets/src/explore/controls.jsx	38.23% <0%> (-3.04%)	⬇️
...ssets/src/visualizations/Funnel/FunnelContainer.js	0% <0%> (ø)
...assets/src/visualizations/Funnel/transformProps.js	0% <0%> (ø)
superset/assets/src/setup/setupPlugins.ts	0% <0%> (ø)	⬆️
...ets/src/visualizations/Funnel/FunnelChartPlugin.js	0% <0%> (ø)
...rset/assets/src/explore/controlPanels/sections.jsx	100% <100%> (ø)	⬆️
.../assets/src/explore/components/controls/Filter.jsx	14.54% <14.54%> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a186ff...dce602c. Read the comment docs.

[TheLastSultan]

Updated @villebro . Just finishing some cleanup efforts and waiting to pass build.

[mistercrunch]

We're in the process of moving all visualizations to live as plugins in other repos. This is very in-flight at the moment. Started writing an example here:
apache-superset/superset-ui-plugins#216

Happy to get on a call to talk about it and help you through the process. You can ping me on the Superset Slack.

[TheLastSultan]

@mistercrunch amazing! Viz.py was getting a little out of hand to say the least :)

Although it is much needed and welcome, "in-flight" is apt for where superset-ui-plugin effort is at the moment. It would be much less time consuming to write a plugin once the legacy plugins are up and functional. Would it be possible to revisit that refactor when the time comes ?

[TheLastSultan]

Bump @etr2460 @mistercrunch

[TheLastSultan]

@etr2460 It's been 10+ days. What is the status of this PR? Can we get some reviewers on it please.

[mistercrunch]

@TheLastSultan , @kristw did a lot of work to migrate all of the visualizations out of the repo, I'm afraid this is a requirement at this point. The closest thing to documentation on how to do this is apache-superset/superset-ui-plugins#216 at this time.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.