TEZ-4569: SCATTER_GATHER + BROADCAST hangs on DAG Recovery

apache · Jun 12, 2024 · 47a8700 · 47a8700
1 parent a34afd7
commit 47a8700
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
@@ -2817,6 +2817,18 @@ private VertexState setupVertex() {
     return VertexState.INITED;
   }
 
+  private boolean canSkipInitializingParents() {
+    // Both cases use RootInputVertexManager. RootInputVertexManager can start tasks even though
+    // any parents are not fully initialized.
+    if (vertexPlan.hasVertexManagerPlugin()) {
+      final VertexManagerPluginDescriptor pluginDesc = DagTypeConverters
+          .convertVertexManagerPluginDescriptorFromDAGPlan(vertexPlan.getVertexManagerPlugin());
+      return pluginDesc.getClassName().equals(RootInputVertexManager.class.getName());
+    } else {
+      return inputsWithInitializers != null;
+    }
+  }
+
   private boolean isVertexInitSkippedInParentVertices() {
     for (Map.Entry<Vertex, Edge> entry : sourceVertices.entrySet()) {
       if(!(((VertexImpl) entry.getKey()).isVertexInitSkipped())) {
@@ -2843,7 +2855,7 @@ private void assignVertexManager() throws TezException {
     if (recoveryData != null && recoveryData.shouldSkipInit()
         && (recoveryData.isVertexTasksStarted() ||
         recoveryData.getVertexConfigurationDoneEvent().isSetParallelismCalled())
-        && isVertexInitSkippedInParentVertices()) {
+        && (canSkipInitializingParents() || isVertexInitSkippedInParentVertices())) {
       // Replace the original VertexManager with NoOpVertexManager if the reconfiguration is done in the last AM attempt
       VertexConfigurationDoneEvent reconfigureDoneEvent = recoveryData.getVertexConfigurationDoneEvent();
       if (LOG.isInfoEnabled()) {