TEZ-4561: Improve reported exception when DAGAppMaster is shutting down. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
I think we can live with this checkstyle warning, creating an accessor method looks like an overkill to me |
|
Added a test. When State is STOPPED |
This comment was marked as outdated.
This comment was marked as outdated.
|
🎊 +1 overall
This message was automatically generated. |
abstractdog
reviewed
Aug 27, 2024
| @@ -1743,6 +1747,13 @@ public void setQueueName(String queueName) { | |||
| } | |||
| } | |||
|
|
|||
| private String getShutdownTimeString() { | |||
| if (shutdownHandler != null && shutdownHandler.shutdownTime != null) { | |||
| return ". The shutdown hook started at " + shutdownHandler.shutdownTime; | |||
There was a problem hiding this comment.
It's strange that this separate string generation method takes care of the closing point of the previous sentence, I believe that should go back to getApplicationACLs
There was a problem hiding this comment.
I moved the "." back to the {{getApplicationACLs}}
|
🎊 +1 overall
This message was automatically generated. |
|
nit: what about changing shutdownTime to private? I guess the usage scope of those are similar |
This comment was marked as outdated.
This comment was marked as outdated.
|
🎊 +1 overall
This message was automatically generated. |
|
@abstractdog I have changed the variable to private & used setter & getter, there was some FindBugs warning, which I have dodged, lemme know if things look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.