[CI] update github workflow for python and include test folder #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fishy this is the follow up of
however i cannot seem to find the cause of it |
|
@fishy do you think this maybe the support of uuid in python is missing? |
jimexist
force-pushed
the
follow-up-python-github-workflow
branch
from
6b57a86 to
bfd2fca
Compare
fishy
reviewed
Apr 27, 2023
test/py/Makefile.am
Outdated
| @@ -71,50 +71,50 @@ TESTS= $(py_unit_tests) | |||
|
|
|||
|
|
|||
| gen-py/%/__init__.py: ../%.thrift $(THRIFT) | |||
| test -f ../v0.16/$(notdir $<) \ | |||
| && $(THRIFT) --gen py ../v0.16/$(notdir $<) \ | |||
| test -f ../$(notdir $<) \ | |||
There was a problem hiding this comment.
we shouldn't change this one. the ones under v0.16 are for the languages not have uuid implemented yet (and python is one of them).
There was a problem hiding this comment.
no not really - i didn't spend time in python impl in the last year or so
jimexist
force-pushed
the
follow-up-python-github-workflow
branch
from
09a0d0a to
fcf3c98
Compare
jimexist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]anywhere in the commit message to free up build resources.