Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApacheThrift.nuspec: Updated to netstandard 2.1 #2867

Closed

Conversation

emmenlau
Copy link
Member

Currently the nuspec file is set to netstandard 2.0. As far as I know, the LTS version is netstandard 2.1. This PR increases the version to the LTS one.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@emmenlau emmenlau added the c# label Oct 12, 2023
@Jens-G
Copy link
Member

Jens-G commented Oct 12, 2023

-1

AFAIK it is still the case that if you want to target both NET framework and NET std the 2.0 is the version of choice. Am I wrong?

https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-1-0#net-standard-not-deprecated

@emmenlau
Copy link
Member Author

Ah, this may explain my problem. I want to share code with .NET Core 3.x and this did not work out of the box. Setting the netstandard to 2.1 helped. But I can see how this may break other use cases.

@Jens-G
Copy link
Member

Jens-G commented Oct 13, 2023

From that same URL:

  • Use netstandard2.0 to share code between .NET Framework and all other implementations of .NET.
  • Use netstandard2.1 to share code between Mono, Xamarin, and .NET Core 3.x.

@emmenlau
Copy link
Member Author

Ok, maybe there is another problem on my side. I will retract this PR!

@emmenlau emmenlau closed this Oct 14, 2023
@emmenlau emmenlau deleted the emmenlau_update_netstd_to_2_1 branch October 14, 2023 08:58
@Jens-G
Copy link
Member

Jens-G commented Oct 14, 2023

BTW, I would love to get rid of that as well. But that use case is not so uncommon I think. We actually use it at our company in exactly that combination where we have certain NET Standard modules included into existing older NET Framework 4.x applications that will most likely never be converted to NET Core for the rest of their life time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants