THRIFT-5819: use latest rustc version for rustlib #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
jimexist
force-pushed
the
rust-lib-use-latest-ver
branch
from
a9f332e to
294e371
Compare
Jens-G
reviewed
Oct 11, 2024
| @@ -2818,7 +2816,7 @@ mod tests { | |||
| copy_write_buffer_to_read_buffer!(o_prot); | |||
|
|
|||
| let read_double = i_prot.read_double().unwrap(); | |||
| assert!(read_double - double < std::f64::EPSILON); | |||
| assert!((read_double - double).abs() < f64::EPSILON); | |||
|
still pending some compile err that i didn't have time to look into. not sure if someone familiar with the rust stack can help. |
|
This warning (which is turned into an error by diff --git a/lib/rs/src/lib.rs b/lib/rs/src/lib.rs
index 84c1f9b71..2f6018810 100644
--- a/lib/rs/src/lib.rs
+++ b/lib/rs/src/lib.rs
@@ -53,7 +53,7 @@
//! [tutorial]: https://github.com/apache/thrift/tree/master/tutorial/rs
#![crate_type = "lib"]
-#![doc(test(attr(allow(unused_variables), deny(warnings))))]
+#![doc(test(attr(allow(unused_variables, dead_code), deny(warnings))))]
#![deny(bare_trait_objects)]
// NOTE: this macro has to be defined before any modules. See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use latest rustc version for rustlib
[skip ci]anywhere in the commit message to free up build resources.