Skip to content

Commit

Permalink
Minor update to GLV examples (#2409)
Browse files Browse the repository at this point in the history
  • Loading branch information
ryn5 authored Dec 20, 2023
1 parent 1e10331 commit 654faed
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
4 changes: 2 additions & 2 deletions bin/run-examples.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ docker pull tinkerpop/gremlin-server
docker run -d --rm -p 8182:8182 --name glv-examples --health-cmd="curl -f http://localhost:8182/ || exit 1" --health-interval=5s --health-timeout=3s tinkerpop/gremlin-server

echo
echo "Not having docker open initially may cause an error loop. If so, simply restart this script."
echo "Not having Docker open initially or occupying port 8182 may cause an error loop. If so, simply restart this script."
echo -n "Starting Gremlin server on port 8182..."
until docker inspect --format '{{.State.Health.Status}}' glv-examples | grep -q "healthy"; do
echo -n "."
sleep 1
done
echo

cd ../gremlin-driver/src/main/java/examples || exit
cd gremlin-driver/src/main/java/examples || exit
mvn clean install

echo
Expand Down
5 changes: 3 additions & 2 deletions docs/src/dev/developer/release.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Take care to commit or not commit changes related to that as necessary.
== Release Manager Requirements
If this is your first time as release manager, you will need to setup keys for signing purposes per the Apache
If this is your first time as release manager, you will need to set up keys for signing purposes per the Apache
release process. Generally speaking, this will mean that you will need to generate a key-pair and then publish your
public key.
Expand Down Expand Up @@ -120,7 +120,6 @@ during this period.
.. Run the full integration test suite: `docker/build.sh -t -i -n`
.. Build and test the Docker images: `mvn clean install -pl gremlin-server,gremlin-console -DdockerImages`
.. Ensure that the Gremlin.Net.Template gets packaged successfully: `mvn clean install -pl :gremlin-dotnet-source -Dnuget`
.. Ensure that the GLV examples are compiling and running successfully: `bin/run-examples.sh`
.. Deploy a final SNAPSHOT to the Apache snapshot repository for Java.
.. Review LICENSE and NOTICE files to make sure that no <<dependencies,changes are needed>>.
.. Review javadoc filters on the "Core API" docs to be sure nothing needs to change.
Expand Down Expand Up @@ -328,6 +327,8 @@ the help of a PMC member for those steps.
.. Commit and push the `SNAPSHOT` changes to git
. Examine the `future.asciidoc` and update the "Roadmap" as needed.
. Send email to advise that code freeze is lifted.
. Ensure that the GLV examples compile and run with the latest image and dependencies: `bin/run-examples.sh`.
.. Make changes as necessary to update the examples.
. Generate a list of dead branches that will be automatically deleted and post them as a DISCUSS thread for review, then once consensus is reached removed those branches.
. Set up the IO tests for the current `SNAPSHOT` as discussed in the <<io,IO Documentation and Testing Section>>
Expand Down
4 changes: 2 additions & 2 deletions gremlin-javascript/examples/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gremlin-javascript/examples/package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "example",
"name": "examples",
"version": "1.0.0",
"description": "GLV example for JavaScript with Node",
"main": "example.js",
"main": "connections.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
Expand Down

0 comments on commit 654faed

Please sign in to comment.