[TINKERPOP-2872] Change JS tests to compare elements by ID for consistency with other GLVs #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryn5
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2422 +/- ##
=============================================
- Coverage 76.17% 76.16% -0.02%
- Complexity 13115 13117 +2
=============================================
Files 1083 1083
Lines 64999 65015 +16
Branches 7259 7260 +1
=============================================
Hits 49516 49516
- Misses 12785 12801 +16
Partials 2698 2698 ☔ View full report in Codecov by Sentry. |
ryn5
changed the title
Cole-Greer
reviewed
Jan 9, 2024
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/element-comparison-test.js
Outdated
Show resolved
Hide resolved
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/element-comparison-test.js
Outdated
Show resolved
Hide resolved
vkagamlyk
reviewed
Jan 9, 2024
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/element-comparison.js
Outdated
Show resolved
Hide resolved
vkagamlyk
reviewed
Jan 9, 2024
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/element-comparison-test.js
Show resolved
Hide resolved
|
Missing a CHANGELOG entry |
|
VOTE+1 |
|
VOTE +1 |
|
Thanks Ryan! VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/projects/TINKERPOP/issues/TINKERPOP-2872
Passes an ID comparator for deep-eql to use when object is type Element, then overwrites chai's members() and isSubsetOf() to use this comparator.