Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unexpected-response handler to gremlin-javascript connection websocket #2935

Closed
wants to merge 2 commits into from

Conversation

KyleBoyer
Copy link

This PR helps provide more information to the end user when a websocket unexpected-response is encountered. This is particularly helpful for using AWS Neptune, which sometimes encounters an "unexpected-response" status code, with a body describing the issue.

@kenhuuu
Copy link
Contributor

kenhuuu commented Dec 2, 2024

Hi and thank you for contributing.

The master branch which is for 4.0 won't support WebSockets so your changes will need to target 3.7-dev instead. The code you are modifying now will be replaced with code that supports HTTP.

Have you noticed the same unexpected-response coming back from Gremlin Server?

@KyleBoyer
Copy link
Author

Sounds good, I'll open a new PR to target the correct branch and close this PR. We have noticed unexpected responses for 3 different situations on AWS Neptune so far. One was a random 400 error status code bug that AWS fixed. Another situation with AWS Neptune was using invalid AWS credentials. Third one we noticed recently is a throttling 500 status code. These situations were difficult to debug before we started reading the body when the web socket hit these unexpected responses.

@KyleBoyer
Copy link
Author

New PR targeting the correct base branch opened here: #2936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants