Use ws WebSocket when options are provided
#2968
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2968 +/- ##
=============================================
+ Coverage 76.14% 76.41% +0.26%
- Complexity 13152 13243 +91
=============================================
Files 1084 1061 -23
Lines 65160 61574 -3586
Branches 7285 7341 +56
=============================================
- Hits 49616 47051 -2565
+ Misses 12839 12002 -837
+ Partials 2705 2521 -184 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 3.7-dev implementation does not pass
headersto the WebSocket when utilizing theglobalThis.WebSocket. This causes issues when initially upgrading to this version of gremlin (or upgrading to Node 22 when the global WebSocket class was enabled by default). This PR ensures that we use thewsWebSocket implementation ifwsspecific options are passed along.