Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to disable request/error counters and cache stats #576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable to disable request/error counters and cache stats #576

wants to merge 1 commit into from

Conversation

rmannibucau
Copy link
Contributor

No description provided.

@ChristopherSchultz
Copy link
Contributor

This seems like a lot of code to avoid two addition operations.

What's the use-case, here?

@rmannibucau
Copy link
Contributor Author

@ChristopherSchultz mainly reduce the associated overhead (cpu - cas - and mem - in no luck case multiple cells are allocated per context) since most of the time these counters are useless as such - it is not rare to either not use them at all or duplicate them in a monitoring solution. In terms of code it is only ~30LoC, rest is the enablement of the counters. Agree it is not critical - why I didnt push it much more, but it is overall weird to enable by default such things and has a cost and is not easy to drop since it is in this particular valve - it would be another it could be dropped, wich can be a better option maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmannibucau @ChristopherSchultz