[DRAFT] WIP on Concurrency work #1090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fyi @tandraschko |
|
Let's see how it looks for a full build, so people can get a chance to dig into test failures: https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/64/ |
|
which failing tests are related to this change? |
|
i dont think that JsfTest stuff is related to this change? and they run on local? |
|
Ok, didn't test them locally, but was of the impression, that the JSF stuff is related as @jgallimore changed the context service stuff inside this PR ;-) |
# Conflicts: # container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
|
The content is here: #1103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased some old code I had prior to CDI 4 to implement the concurrency spec changes. Still working on unit test failures, and likely isn't complete.
I'll keep plugging away, but equally happy for someone else to incorporate this into another PR, or trash this and do something else, or whatever.