Update cython bindings to use kTVMArgBool

apache · Apr 22, 2024 · 4bda95c · 4bda95c
1 parent 09bbb80
commit 4bda95c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/python/tvm/_ffi/_cython/base.pxi b/python/tvm/_ffi/_cython/base.pxi
@@ -16,6 +16,7 @@
 # under the License.
 
 from ..base import raise_last_ffi_error
+from libcpp cimport bool as bool_t
 from libcpp.vector cimport vector
 from cpython.version cimport PY_MAJOR_VERSION
 from cpython cimport pycapsule
@@ -38,7 +39,8 @@ cdef enum TVMArgTypeCode:
     kTVMBytes = 12
     kTVMNDArrayHandle = 13
     kTVMObjectRefArg = 14
-    kTVMExtBegin = 15
+    kTVMArgBool = 15
+    kTVMExtBegin = 16
 
 cdef extern from "tvm/runtime/c_runtime_api.h":
     ctypedef struct DLDataType:
@@ -66,6 +68,7 @@ cdef extern from "tvm/runtime/c_runtime_api.h":
 
     ctypedef struct TVMValue:
         int64_t v_int64
+        bool_t v_bool
         double v_float64
         void* v_handle
         const char* v_str

diff --git a/python/tvm/_ffi/_cython/packed_func.pxi b/python/tvm/_ffi/_cython/packed_func.pxi
@@ -121,10 +121,8 @@ cdef inline int make_arg(object arg,
     elif isinstance(arg, bool):
         # A python `bool` is a subclass of `int`, so this check
         # must occur before `Integral`.
-        arg = _FUNC_CONVERT_TO_OBJECT(arg)
-        value[0].v_handle = (<ObjectBase>arg).chandle
-        tcode[0] = kTVMObjectHandle
-        temp_args.append(arg)
+        value[0].v_bool = arg
+        tcode[0] = kTVMArgBool
     elif isinstance(arg, Integral):
         value[0].v_int64 = arg
         tcode[0] = kInt