Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Revert " [FFI] Re-introduce the boxed primitive values (#17257)" #17272

Closed

Conversation

Lunderberg
Copy link
Contributor

This reverts commit 02f48828e4b56995be0021c9a98e1705a837e712. The post-merge builds on main are failing in CI on both MacOS and Windows. The failure modes do not appear to be caused by the FFI changes, but the FFI changes impact enough parts of TVM that it's difficult to say that definitively.

This reverts commit `02f48828e4b56995be0021c9a98e1705a837e712`.  The
post-merge builds on `main` are failing in CI on both MacOS and
Windows.  The failure modes do not appear to be caused by the FFI
changes, but the FFI changes impact enough parts of TVM that it's
difficult to say that definitively.
@Lunderberg
Copy link
Contributor Author

If the CI fails in the "CI / MacOS" and "CI / Windows" builds, that will indicate that the current build failures on main are unrelated to the changes in #17257.

@Lunderberg
Copy link
Contributor Author

The CI for this PR fails with the same errors as seen on main (copied below), so the FFI changes are unrelated to the build failures. Closing this PR, as it is not necessary to revert the FFI changes.


For the MacOS build:

conda.exceptions.CondaValueError: You have chosen a non-default solver backend (libmamba) but it was not recognized. Choose one of: classic

For the Windows build:

MSBUILD : error MSB1009: Project file does not exist.
Switch: install.vcxproj
cp: cannot stat 'C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1723485650581\_h_env\Library\lib\tvm.dll': No such file or directory
cp: cannot stat 'C:\Miniconda\envs\tvm-build\conda-bld\tvm-package_1723485650581\_h_env\Library\lib\tvm_runtime.dll': No such file or directory

BuildScriptException: Command '['C:\\Windows\\system32\\cmd.exe', '/d', '/c', 'C:\\Miniconda\\envs\\tvm-build\\conda-bld\\tvm-package_1723485650581\\work\\install_libtvm.bat']' returned non-zero exit status 1.

@Lunderberg Lunderberg closed this Aug 13, 2024
@Lunderberg Lunderberg deleted the draft_ffi_revert_boxed_primitives branch August 13, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant