[Relax][Frontend][Onnx] Add auto_pad support for conv #17536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
reviewed
Nov 20, 2024
| @@ -1022,6 +1022,57 @@ def _verify_conv(input_shape, weight_shape): | |||
| _verify_conv([3, 4, 32, 32, 32], [2, 4, 3, 3, 3]) # group=2 | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("stride", [1, 2]) | |||
There was a problem hiding this comment.
Can we combine the tests into test_conv? Looks like they are almost the same:)
There was a problem hiding this comment.
I got 'Dilation not supported for AutoPadType::SAME_UPPER or AutoPadType::SAME_LOWER' while using onnxruntime. If I add '@pytest.mark.parametrize("auto_pad", ["SAME_UPPER", "SAME_LOWER", "VALID", "NOTSET"])', I should skip dilation=2 for "SAME_UPPER" and "SAME_LOWER". I'm just not sure if this approach is okay.
Hzfengsy
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto_pad support for conv.