Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link for angular demo #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

siddhant-dev
Copy link

@siddhant-dev siddhant-dev commented Jul 26, 2024

Hi @aparajita
I have create an angular demo with your plugin and would love to showcase it in your main repo.
I have updated the readme file to add my demo project's link.

Before merging please go through demo project once and let me if any changes is required.
Angular Demo

@aparajita
Copy link
Owner

Thanks, I'll take a look.

@aparajita
Copy link
Owner

Sorry, I can't link to it as it is now. Just a quick look reveals:

  • Formatting issues.
  • Crashes on iOS because NSFaceIDUsageDescription is missing.

There is probably more. Details matter!

@siddhant-dev
Copy link
Author

I tested it on android no worries will add the iOS permissions as well.
For formatting I used prettier if you have any other tool in mind let me know I'll update it accordingly

@siddhant-dev
Copy link
Author

update info.plist file

@aparajita
Copy link
Owner

For formatting I used prettier if you have any other tool in mind let me know I'll update it accordingly

I'm talking about the formatting in the interface. Look more closely at how I format things.

Please remove the icon next to the Authenticate button. It is pushing "Authenticate" into the view title on iOS.

@siddhant-dev
Copy link
Author

Update the formatting

@siddhant-dev
Copy link
Author

Hi @aparajita
I have updated the look and feel to match it your demo

@siddhant-dev
Copy link
Author

Hi @aparajita
Can you merge this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants