Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #114

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Develop #114

wants to merge 13 commits into from

Conversation

jffcovey
Copy link

@jffcovey jffcovey commented Jan 6, 2021

I would like to contribute a bug fix related to this library and Internet Explorer. The issue is outlined in this blog post. https://blogs.perficient.com/2017/03/27/troubleshooting-the-redirect-issue-of-net-cas-integration-in-ie/

@phantomtypist
Copy link
Contributor

Which versions of IE does this effect?

@phantomtypist
Copy link
Contributor

Did you also try the most recent version of the nuget package to see if the problem actually still existed? The problem they described in the four year old blog article is a TLS related problem for a cyclical redirect issue. From what I can tell they just made a bandaid fix, but the problem was still there in reality.

If I am wrong, please provide fully reproduction scenario, including version of IE, with most current nuget package, step by step, so that we can test and verify the problem still exists.

@jffcovey
Copy link
Author

jffcovey commented Jan 6, 2021

Sorry, this is my first time trying to contribute to a project on Github. I forked, pushed my changes and created a new pull request.

@jffcovey jffcovey closed this Jan 6, 2021
@phantomtypist
Copy link
Contributor

@jffcovey you didn't have to close the issue, just answer the questions I asked. I mean, you put in all that effort writing that blog post back in 2017 and the investigative debugging, I figured it wasn't too much to ask of you to test your problem against the latest release in nuget to see if the problem was still there or not.

@phantomtypist phantomtypist reopened this Jan 6, 2021
@jffcovey
Copy link
Author

jffcovey commented Jan 7, 2021

I didn't write that blog. I ran across it while triaging a bug that we have with the latest nuget package(1.3.2). If you try to use it with IE 11 I think you will see the same behavior. I created a new pull request with the code change we implemented that fixed the issue. We're fine with maintaining our own customized version of the code, but just thought it would be helpful to contribute back to the project.

@phantomtypist
Copy link
Contributor

What version of TLS is both the web application server running and the CAS server running? What version of. Net is your application compiled against (be specific)

@jffcovey
Copy link
Author

jffcovey commented Jan 7, 2021

Both servers are running TLS 1.2 and we are using .NET Framework 4.6.1 to compile our application. Also, version 1.3.2 of DotNetCasClient.

@jffcovey
Copy link
Author

Is there anything else you need from me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants