Maintenance & Security Update Rollup #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rdev5
commented
Mar 19, 2015
rdev5
commented
- Merge NETC-55 (https://issues.jasig.org/browse/NETC-55), same as Issue https://issues.jasig.org/browse/NETC-55 #8; related to Issue RequestEvaluator.GetRequestIsAppropriateForCasAuthentication() seems incomplete and appears to be causing redirect loop #25.
- Merge Issue Dynamic proxyCallbackUrl not suitable for static proxy chain configuration #23.
- Add SecureClient class.
- Add clearPassGetRequest to CasClientConfiguration.
- Implement GetSecurePassword.
- Deprecate GetPassword.
…t Manager, and the Ticket Validator. Allow for type aliases for easy configuration and backwards-compatability in the casClientConfig.
…er fully-qualified or one of the predefined configuration strings
Closed
rdev5
changed the title
|
Please take a moment to review this pull request. Includes previously discussed updates and a more secure implementation of GetPassword in 861c00d. On a side note, should I be looking into submitting an ICLA these days? |
The proxyGrantingTicket can be null if the cache is expired. When the proxyGrantingTicket is null and calling InsertProxyGrantingTicketMapping will throw exception and causing redirection loop.
Fixing redirection loop bug
Provide utility to get assertion attributes.
NETC-51: Use reflection to find types for the Service/Proxy Ticket Manager/Validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.