Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleSignOut causes A potentially dangerous Request.Form exception #81

Closed
wants to merge 1 commit into from
Closed

SingleSignOut causes A potentially dangerous Request.Form exception #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DotNetCasClient/CasAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,13 +737,13 @@ internal static void ProcessSingleSignOutRequest()

protoLogger.Debug("Examining request for single sign-out signature");

if (request.HttpMethod == "POST" && request.Form["logoutRequest"] != null)
if (request.HttpMethod == "POST" && request.Unvalidated.Form["logoutRequest"] != null)
{
protoLogger.Debug("Attempting to get CAS service ticket from request");
// TODO: Should we be checking to make sure that this special POST is coming from a trusted source?
// It would be tricky to do this by IP address because there might be a white list or something.

string casTicket = ExtractSingleSignOutTicketFromSamlResponse(request.Params["logoutRequest"]);
string casTicket = ExtractSingleSignOutTicketFromSamlResponse(request.Unvalidated.Form["logoutRequest"]);
if (!String.IsNullOrEmpty(casTicket))
{
protoLogger.Info("Processing single sign-out request for " + casTicket);
Expand Down