Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T1192 : 1 line bug fix in Visualizer, and setup timer for average frame rate measurement in firmware #42

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

eppisai
Copy link
Contributor

@eppisai eppisai commented Aug 26, 2021

hi,
this pull request is regarding code review of some small changes that i have made, so can get them merged and proceed with tasks further

changes made

  • included the cpp files of widget to cmake of visualizer, so it works again
  • added timer for avg framerate measurement

Copy link
Member

@BAndiT1983 BAndiT1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad formatting, empty lines are missing or too many.

have added an empty line, at the start of InitTimer2 , and added a empty line before configGPIO() . Removed empty lines from int main() start and in interupt for timer2
@eppisai
Copy link
Contributor Author

eppisai commented Aug 26, 2021

Bad formatting, empty lines are missing or too many.

oh..that was quick.. thank you so much, @BAndiT1983 is above okay?

@eppisai eppisai changed the title 1 line bug fix in Visualizer, and setup timer for average frame rate measurement in firmware T1192 : 1 line bug fix in Visualizer, and setup timer for average frame rate measurement in firmware Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants