fflib-apex-common | mateuszzw | add addCondition() method to QueryFactory #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ImJohnMDaniel it's open for a long time already. I know you're probably extra busy, but is there any chance for you to take a look at it? Thanks! |
|
@ImJohnMDaniel @stohn777 This looks interesting. What are you're thoughts on this being included? |
|
This change is under review but we are currently focusing on efforts to incorporate USER_MODE. Once we get this stable, then we will focus on other efforts like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ImJohnMDaniel
Since our team had a need for a method that adds to already existing conditions and not just setting them, here's my pull request to add that functionality. Feel free to comment, I'm really curious what you think :)
This change is