Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #2016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ describe('extract and encode multiple values', () => {
).toThrow('Parameter "_path" must be empty string or undefined when "_type" is "timestamp", but it was "1"');
});

it('throws if _times is present for non numberic types', () => {
it('throws if _times is present for non numeric types', () => {
const encodedString = ethers.utils.formatBytes32String('simplestring');
expect(() => extractAndEncodeResponse(encodedString, { _type: 'bytes32', _times: '1000' })).toThrow(
'Parameter "_times" can only be used with numeric types, but "_type" was "bytes32"'
Expand Down
4 changes: 2 additions & 2 deletions packages/airnode-admin/test/e2e/cli.feature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('CLI', () => {
it('derives airnode xpub', () => {
const airnodeMnemonic = airnodeWallet.mnemonic.phrase;

// Derive the xpub programatically
// Derive the xpub programmatically
const airnodeXpub = admin.deriveAirnodeXpub(airnodeMnemonic);

// Derive the xpub using CLI
Expand Down Expand Up @@ -172,7 +172,7 @@ describe('CLI', () => {
['--sponsor-address', sponsorAddress]
);

// Derive the wallet programatically
// Derive the wallet programmatically
const sponsorWallet = await deriveSponsorWallet(airnodeWallet.mnemonic.phrase, sponsorAddress);

// Check that they generate the same wallet address
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const main = async () => {
// NOTE: When doing this manually, you can use the 'derive-airnode-xpub' command from the admin CLI package
const airnodeXpub = deriveAirnodeXpub(airnodeWallet.mnemonic.phrase);

// Derive the sponsor wallet address programatically
// Derive the sponsor wallet address programmatically
// NOTE: When doing this manually, you can use the 'derive-sponsor-wallet-address' command from the admin CLI package
const sponsorWalletAddress = await deriveSponsorWalletAddress(airnodeXpub, airnodeWallet.address, sponsor.address);

Expand Down
Loading