Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: vale fixes #1433

Merged
merged 2 commits into from
Jan 27, 2025
Merged

docs: vale fixes #1433

merged 2 commits into from
Jan 27, 2025

Conversation

TC-MO
Copy link
Contributor

@TC-MO TC-MO commented Jan 27, 2025

Add various exemptions to accept.txt
fix initial issues within academy

TC-MO added 2 commits January 27, 2025 02:01
Add various exemptions to accept.txt
fix initial issues within academy
adjust regex
add new exemptions to accept.txt
fixed typos
@TC-MO TC-MO requested a review from honzajavorek as a code owner January 27, 2025 01:19
@TC-MO TC-MO self-assigned this Jan 27, 2025
@github-actions github-actions bot added the t-docs Issues owned by technical writing team. label Jan 27, 2025
@TC-MO TC-MO added documentation Improvements or additions to documentation. adhoc Ad-hoc unplanned task added during the sprint. labels Jan 27, 2025
Copy link
Collaborator

@honzajavorek honzajavorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accept.txt can be optimized, but I don't think it should block merging this PR.

screenshotting
Fakestore
SKUs
SKU
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SKUs? should be the same as separate SKU and SKUs (the same is valid for the other terms)

@TC-MO TC-MO merged commit 4c7811e into master Jan 27, 2025
7 checks passed
@TC-MO TC-MO deleted the fix-vale-issues branch January 27, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. documentation Improvements or additions to documentation. t-docs Issues owned by technical writing team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants