Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for PHPCS Fixes #380

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Changes for PHPCS Fixes #380

merged 3 commits into from
Oct 3, 2024

Conversation

kedarkhaire
Copy link
Collaborator

PHPCS fix includes the following fixes

  1. Use statement sort in alphabetically order
  2. Parameter has null default value, but is not marked as nullable.
  3. Fix fully_qualified_strict_type, global_namespace_import, phpdoc_separation, ordered_imports

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 21 lines in your changes missing coverage. Please review.

Project coverage is 86.85%. Comparing base (a56e3fe) to head (fe9d16e).
Report is 1 commits behind head on 3.x.

Files with missing lines Patch % Lines
src/Api/Management/Controller/AppController.php 0.00% 5 Missing ⚠️
src/Api/ApigeeX/Controller/AppController.php 0.00% 4 Missing ⚠️
.../Management/Controller/AppCredentialController.php 50.00% 3 Missing ⚠️
src/PropertyAccess/PropertyAccessorDecorator.php 71.42% 2 Missing ⚠️
src/Structure/KeyValueMap.php 0.00% 2 Missing ⚠️
...c/Api/ApigeeX/Controller/AppGroupAppController.php 0.00% 1 Missing ⚠️
...ApigeeX/Controller/PaginatedListingHelperTrait.php 0.00% 1 Missing ⚠️
src/Api/Management/Entity/Organization.php 0.00% 1 Missing ⚠️
src/Exception/CpsNotEnabledException.php 0.00% 1 Missing ⚠️
src/Serializer/JsonDecode.php 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #380      +/-   ##
============================================
+ Coverage     86.81%   86.85%   +0.03%     
  Complexity     1768     1768              
============================================
  Files           349      349              
  Lines          4643     4641       -2     
============================================
  Hits           4031     4031              
+ Misses          612      610       -2     
Flag Coverage Δ
unittests 86.85% <84.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ApigeeX/Controller/AcceptedRatePlanController.php 86.48% <100.00%> (ø)
...rc/Api/ApigeeX/Controller/ApiProductController.php 80.00% <ø> (ø)
...rc/Api/ApigeeX/Controller/AppByOwnerController.php 100.00% <100.00%> (ø)
...eeX/Controller/AppGroupAppCredentialController.php 100.00% <ø> (ø)
...pigeeX/Controller/AppGroupAwareControllerTrait.php 0.00% <ø> (ø)
src/Api/ApigeeX/Controller/AppGroupController.php 100.00% <100.00%> (ø)
...c/Api/ApigeeX/Controller/BillingTypeController.php 100.00% <ø> (ø)
...Controller/DeveloperAcceptedRatePlanController.php 64.70% <ø> (ø)
...geeX/Controller/DeveloperBillingTypeController.php 100.00% <ø> (ø)
...X/Controller/DeveloperPrepaidBalanceController.php 100.00% <ø> (ø)
... and 211 more

@kedarkhaire
Copy link
Collaborator Author

Following commands were used to analyze and fix the PHPCS issues and then check the flow again.

  1. Report code style issues that can not be fixed automatically - composer check-style
  2. Automatically fix code style issues - composer fix-style
  3. Check for errors with the static code-analysis tool post above changes - composer analyze
  4. Run PHPUnit tests to check all the test-cases are running well post above changes - composer test

Thanks!

@kedarkhaire kedarkhaire self-assigned this Oct 1, 2024
@giteshk giteshk merged commit f43f83e into apigee:3.x Oct 3, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants