Update apigee_edge_apiproduct_rbac.module bug fix issue 1098

[urbanenomad]

Changed from neutral to forbidden so that API Products do not show up on the assign operation or Create App when using the RBAC service to control access to API Products. This is to solve issue #1098

[kedarkhaire]

Hi @urbanenomad Thanks for creating the PR, we will check the implementation, but also it is mandatory that all tests pass in your repository, to make sure that the other working functionalities are unharmed.

Thanks!

[urbanenomad]

I am a bit confused on some of these errors. There seems to be some kind of JWT token error in PHP 81./Drupal 10.3.x/X

"1) Drupal\Tests\apigee_edge_teams\Functional\ApigeeX\AccessTest::testAccess
Drupal\Core\Entity\EntityStorageException: "error":"invalid_grant","error_description":"Invalid JWT Signature."".

I am not sure why this error is occuring. I don't think I did any changes to the JWT signature? Do I need to test the code against a working apigee-x instance?

[kedarkhaire]

ror is occuring. I don't think I did any changes

Hi @urbanenomad
Yes the issue is not related to the changes you made, we just need to update the credentials for test. I will do that tomorrow with the working ones, and that issue will be solved.

I saw other issue on my test fork. Can you have a look at this link.

[urbanenomad]

I don't have an active apigee edge instance that seems to be something I need to test these unit tests. Is there a public one I can use to validate the unit tests from my fork?

[urbanenomad]

@kedarkhaire another thing I see is that your kedarkhaire fork there seems to be 2 errors for similar issues for both AccessTest::testAcccess as well as UiTest::testUi. But in the original repo there only seems to be one error for the UiTest::testUi. Both seems to be based on the same error where it looks like the team_name doesn't seem to exist which is causing the undefined array key error? Also my apigee-x instance I have for testing the drupal portal seems to have monetization turned on so apigee-teams module does not seem to work in my portal since it is not designed to work with monetization turned on. Is there another apigee instance edge or x that we can use to test this?

[kedarkhaire]

Hi @urbanenomad
Thanks for your inputs, I will check and update.