Skip to content

Commit

Permalink
Replace request module with postman-request (#234)
Browse files Browse the repository at this point in the history
The request module is no longer under development
 It pulls in dependencies with vulnerabilities. So, switching to
 postman-request that is currently being maintained.

Co-authored-by: Keyur Karnik <[email protected]>
  • Loading branch information
keyurkarnik and kkkarnik authored Dec 12, 2023
1 parent 42c96cf commit 9eea7de
Show file tree
Hide file tree
Showing 8 changed files with 871 additions and 556 deletions.
2 changes: 1 addition & 1 deletion lib/commands/fetchproxy.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
'use strict';

var fs = require('fs');
var request = require('request');
var request = require('postman-request');
var util = require('util');

var defaults = require('../defaults');
Expand Down
2 changes: 1 addition & 1 deletion lib/commands/fetchsharedflow.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
'use strict';

const fs = require('fs'),
request = require('request'),
request = require('postman-request'),
util = require('util'),
defaults = require('../defaults'),
options = require('../options'),
Expand Down
2 changes: 1 addition & 1 deletion lib/defaults.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* jshint node: true */
'use strict';

const request = require('request'),
const request = require('postman-request'),
url = require('url'),
fs = require('fs'),
netrc = require('netrc')();
Expand Down
1,413 changes: 864 additions & 549 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"netrc": "^0.1.3",
"node-unzip-2": "^0.2.7",
"read": "^1.0.7",
"request": "^2.88.0",
"postman-request": "^2.88.1-postman.33",
"tar-fs": "^2.1.1",
"tmp": "^0.0.27"
},
Expand Down
2 changes: 1 addition & 1 deletion remotetests/remotetest.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const apigeetool = require('..'),
async = require('async'),
path = require('path'),
fs = require('fs'),
request = require('request'),
request = require('postman-request'),
util = require('util'),
stream = require('stream'),
faker = require('faker');
Expand Down
2 changes: 1 addition & 1 deletion test/testbackend.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const assert = require('assert'),
childProcess = require('child_process'),
path = require('path'),
requestModule = require('request'),
requestModule = require('postman-request'),
request = requestModule.defaults({
json: true
}),
Expand Down
2 changes: 1 addition & 1 deletion test/testoptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var util = require('util');
var options = require('../lib/options');
var defaults = require('../lib/defaults');
var fs = require('fs');
var request = require('request');
var request = require('postman-request');

describe('Options parsing test', function() {
beforeAll(function () {
Expand Down

0 comments on commit 9eea7de

Please sign in to comment.