Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sackmesser report - inconsistent directory names #644

Open
OmidTahouri opened this issue Feb 8, 2023 · 1 comment
Open

Sackmesser report - inconsistent directory names #644

OmidTahouri opened this issue Feb 8, 2023 · 1 comment
Labels
enhancement New feature or request nice-to-have

Comments

@OmidTahouri
Copy link
Collaborator

OmidTahouri commented Feb 8, 2023 •
edited
Loading

We have a minor inconsistency with the directory names created for sackmesser report
Each resource in /tools/apigee-sackmesser/cmd/report/helpers will have its own directory created

e.g.
mkdir -p "$export_folder/$organization/config/resources/edge/env/$environment/company"

This issue raises the question of whether the directory names should be singular or plural; /company vs /companies

/api-products ✅
/caches ✅
/developerapps (hyphen?)
/developers ✅
/flowhook
/keystore
/kvm
/reference
/target-servers ✅
/user
/virtualhost
@OmidTahouri OmidTahouri added enhancement New feature or request nice-to-have labels Feb 8, 2023
@OmidTahouri
Copy link
Collaborator Author

Just FYI @g-devpat @g-greatdevaks

@OmidTahouri OmidTahouri mentioned this issue Feb 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request nice-to-have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OmidTahouri