Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added unsupported apis in report #637

Merged
merged 5 commits into from
Feb 8, 2023

Conversation

g-devpat
Copy link
Contributor

@g-devpat g-devpat commented Jan 2, 2023

Description

What's changed, or what was fixed?
Added capability to report the following Apigee OPDK resources:

  • Companies
  • Company Apps
  • LDAP resources
  • Users

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

@g-devpat g-devpat marked this pull request as ready for review January 2, 2023 11:46
@OmidTahouri
Copy link
Collaborator

/gcbrun

@OmidTahouri
Copy link
Collaborator

/gcbrun

1 similar comment
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/apigee-sackmesser pass 291s
TOTAL PIPELINE pass 291s

View details in Cloud Build (permission required)

Commit version: c7b960f

@OmidTahouri OmidTahouri self-requested a review February 8, 2023 11:13
tools/apigee-sackmesser/cmd/report/report.sh Outdated Show resolved Hide resolved

echo "<h3>Companies</h3>" >> "$report_html"

mkdir -p "$export_folder/$organization/config/resources/edge/env/$environment/company"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/company instead of /companies but I see the existing implementation has an inconsistent approach for dir names of other resources, so I won't request this change

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised #644 to track this later

tools/apigee-sackmesser/cmd/report/helpers/companies.sh Outdated Show resolved Hide resolved
@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/apigee-sackmesser pass 354s
TOTAL PIPELINE pass 354s

View details in Cloud Build (permission required)

Commit version: 130e19f

@OmidTahouri OmidTahouri merged commit 0f776f6 into apigee:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants