Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve deployment query performance #1211

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Conversation

theganyo
Copy link
Member

@theganyo theganyo commented Jul 6, 2023

  • added index to deployments
  • added page size to visitors
  • changed registry get page size to 1k
  • fixed missed filter passing in visitors where found

Fixes #1208

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1211 (d2a7b24) into main (31e01c2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   71.82%   71.84%   +0.01%     
==========================================
  Files         146      146              
  Lines       12179    12179              
==========================================
+ Hits         8748     8750       +2     
+ Misses       2750     2748       -2     
  Partials      681      681              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@theganyo
Copy link
Member Author

theganyo commented Jul 7, 2023

@timburks Thanks for the review, but this is still WIP - unless you'd rather a separate PR for the page size changes we need to discuss in #1208.

@theganyo theganyo marked this pull request as ready for review July 10, 2023 18:58
Copy link
Contributor

@timburks timburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It might be counterintuitive to see all the zero page sizes, but I guess people will figure out that this means use the API's default limit... we're basically relying on protocol buffers code to drop zero values (and not send them) when we set limits. Just thinking out loud...

@theganyo theganyo merged commit 680bdef into apigee:main Jul 10, 2023
@theganyo theganyo deleted the theganyo/issue1208 branch July 10, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Registry server: listing deployments seems slow
2 participants