Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: outgiong request null parent id bug #47

Merged
merged 9 commits into from
Nov 6, 2023
Merged

fix: outgiong request null parent id bug #47

merged 9 commits into from
Nov 6, 2023

Conversation

dawkaka
Copy link
Contributor

@dawkaka dawkaka commented Nov 3, 2023

No description provided.

@tonyalaribe
Copy link
Contributor

Add a test that checks that that issue no longer happens

@tonyalaribe
Copy link
Contributor

I'm merging this. But two important points:

  1. Run fmt on this branch. make fmt. or go fmt
  2. Can the tests confirm that even when an outgoing call is made without being in a handler, that it doesn't panic and just fails with a log?

@tonyalaribe tonyalaribe merged commit e5ec4b8 into main Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyalaribe tonyalaribe tonyalaribe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawkaka @tonyalaribe