Include fixes from wojodesign#277, wojodesign#322, wojodesign#368

apokaliptis · Mar 31, 2021 · a3452b3 · a3452b3
1 parent 51a9a38
commit a3452b3
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/simpleCart.js b/simpleCart.js
@@ -440,7 +440,16 @@
 						items[item.id()] = simpleCart.extend(item.fields(), item.options());
 					});
 
-					localStorage.setItem(namespace + "_items", JSON.stringify(items));
+					// try statement to catch storing errors and avoid
+					// QUOTA_EXCEEDED_ERR issues in safari 
+					if (!!window.localStorage) {
+						try {
+							localStorage.setItem(namespace + "_items", JSON.stringify(items));						
+						}
+						catch (e){
+							simpleCart.error( "Error storing data: " + e );
+						}
+					}
 
 					simpleCart.trigger('afterSave');
 				},
@@ -1032,7 +1041,7 @@
 						data['item_name_' + counter]		= item.get('name');
 						data['item_quantity_' + counter]	= item.quantity();
 						data['item_price_' + counter]		= item.price();
-						data['item_currency_ ' + counter]	= simpleCart.currency().code;
+						data['item_currency_' + counter]	= simpleCart.currency().code;
 						data['item_tax_rate' + counter]		= item.get('taxRate') || simpleCart.taxRate();
 
 						// create array of extra options
@@ -1094,7 +1103,7 @@
 						data['item_title_' + counter]			= item.get('name');
 						data['item_quantity_' + counter]		= item.quantity();
 						data['item_price_' + counter]			= item.price();
-						data['item_sku_ ' + counter]			= item.get('sku') || item.id();
+						data['item_sku_' + counter]			= item.get('sku') || item.id();
 						data['item_merchant_id_' + counter]	= opts.merchant_id;
 						if (item.get('weight')) {
 							data['item_weight_' + counter]		= item.get('weight');
@@ -1790,9 +1799,11 @@
 											attr = klass.split("_")[1];
 											val = "";
 											switch($item.tag().toLowerCase()) {
-												case "input":
 												case "textarea":
 												case "select":
+													val = $item.val();
+													break
+												case "input":
 													type = $item.attr("type");
 													if (!type || ((type.toLowerCase() === "checkbox" || type.toLowerCase() === "radio") && $item.attr("checked")) || type.toLowerCase() === "text" || type.toLowerCase() === "number") {
 														val = $item.val();