address review comments, fix maintained libs/repos

apollographql · Oct 20, 2023 · 713e917 · 713e917
1 parent e4b2d56
commit 713e917
Show file tree

Hide file tree

Showing 15 changed files with 18 additions and 17 deletions.
diff --git a/implementations/apollo-server/metadata.json b/implementations/apollo-server/metadata.json
@@ -6,16 +6,17 @@
   "repository": {
     "name": "apollo-server",
     "owner": "apollographql",
+    "maintainer" : "apollographql",
     "link": "https://github.com/apollographql/apollo-server"
   },
   "coreLibrary": {
     "name": "GraphQL.js",
-    "owner": "apollographql",
+    "maintainer": "apollographql",
     "link": "https://www.npmjs.com/package/graphql"
   },
   "federationlibrary": {
     "name": "Apollo Subgraph",
-    "owner": "apollographql",
+    "maintainer": "apollographql",
     "link": "https://www.npmjs.com/package/@apollo/subgraph"
   }
 }
diff --git a/implementations/async-graphql/metadata.json b/implementations/async-graphql/metadata.json
@@ -6,7 +6,6 @@
   "repository": {
     "name": "async-graphql",
     "owner": "async-graphql",
-    "maintainer": "apollographql",
     "link": "https://github.com/async-graphql/async-graphql"
   }
 }
diff --git a/implementations/dgs/metadata.json b/implementations/dgs/metadata.json
@@ -15,6 +15,7 @@
   "federationlibrary": {
     "name": "federation-jvm",
     "owner": "apollographql",
+    "maintainer" : "apollographql",
     "link": "https://github.com/apollographql/federation-jvm"
   }
 }
diff --git a/implementations/express-graphql/metadata.json b/implementations/express-graphql/metadata.json
@@ -14,6 +14,7 @@
   },
   "federationlibrary": {
     "name": "Apollo Subgraph",
+    "maintainer" : "apollographql",
     "link": "https://www.npmjs.com/package/@apollo/subgraph"
   }
 }
diff --git a/implementations/graphql-java-kickstart/metadata.json b/implementations/graphql-java-kickstart/metadata.json
@@ -15,6 +15,7 @@
   "federationlibrary": {
     "name": "federation-jvm",
     "owner": "apollographql",
+    "maintainer": "apollographql",
     "link": "https://github.com/apollographql/federation-jvm"
   }
 }
diff --git a/implementations/graphql-yoga/metadata.json b/implementations/graphql-yoga/metadata.json
@@ -15,6 +15,7 @@
   },
   "federationlibrary": {
     "name": "Apollo Subgraph",
+    "maintainer" : "apollographql",
     "link": "https://www.npmjs.com/package/@apollo/subgraph"
   }
 }
diff --git a/implementations/helix/metadata.json b/implementations/helix/metadata.json
@@ -15,6 +15,7 @@
   },
   "federationlibrary": {
     "name": "Apollo Subgraph",
+    "maintainer" : "apollographql",
     "link": "https://www.npmjs.com/package/@apollo/subgraph"
   }
 }
diff --git a/implementations/hotchocolate/metadata.json b/implementations/hotchocolate/metadata.json
@@ -12,6 +12,7 @@
   "federationlibrary": {
     "name": "federation-hotchocolate",
     "owner": "apollographql",
+    "maintainer": "apollographql",
     "link": "https://github.com/apollographql/federation-hotchocolate"
   }
 }
diff --git a/implementations/mercurius/metadata.json b/implementations/mercurius/metadata.json
@@ -14,6 +14,7 @@
   },
   "federationlibrary": {
     "name": "Apollo Subgraph",
+    "maintainer" : "apollographql",
     "link": "https://www.npmjs.com/package/@apollo/subgraph"
   }
 }
diff --git a/implementations/neo4j-graphql/metadata.json b/implementations/neo4j-graphql/metadata.json
@@ -14,6 +14,7 @@
     },
     "federationlibrary": {
         "name": "Apollo Subgraph",
+        "maintainer" : "apollographql",
         "link": "https://www.npmjs.com/package/@apollo/subgraph"
     }
 }
diff --git a/implementations/nestjs-code-first/metadata.json b/implementations/nestjs-code-first/metadata.json
@@ -15,6 +15,7 @@
   },
   "federationlibrary": {
     "name": "Apollo Subgraph",
+    "maintainer" : "apollographql",
     "link": "https://www.npmjs.com/package/@apollo/subgraph"
   }
 }
diff --git a/implementations/nestjs/metadata.json b/implementations/nestjs/metadata.json
@@ -15,6 +15,7 @@
   },
   "federationlibrary": {
     "name": "Apollo Subgraph",
+    "maintainer" : "apollographql",
     "link": "https://www.npmjs.com/package/@apollo/subgraph"
   }
 }
diff --git a/implementations/spring-graphql/metadata.json b/implementations/spring-graphql/metadata.json
@@ -15,6 +15,7 @@
   "federationlibrary": {
     "name": "federation-jvm",
     "owner": "apollographql",
+    "maintainer": "apollographql",
     "link": "https://github.com/apollographql/federation-jvm"
   }
 }
diff --git a/implementations/strawberry-graphql/metadata.json b/implementations/strawberry-graphql/metadata.json
@@ -7,7 +7,6 @@
     "name": "strawberry",
     "owner": "strawberry-graphql",
     "link": "https://github.com/strawberry-graphql/strawberry",
-    "maintainer": "apollographql"
   },
   "coreLibrary": {
     "name": "GraphQL-core 3",

diff --git a/packages/compatibility/src/utils/markdown.ts b/packages/compatibility/src/utils/markdown.ts
@@ -64,7 +64,7 @@ class MarkdownFile {
 
 | Icon | Description                                          |
 | ---- | ---------------------------------------------------- |
-| ${apolloIcon} | Library is maintained by Apollo |
+| ${apolloIcon} | Maintained by Apollo |
 | 🟢    | Functionality is supported                           |
 | ❌    | Critical functionality is NOT supported              |
 | 🔲    | Additional federation functionality is NOT supported |
@@ -143,10 +143,7 @@ class MarkdownFile {
       let repoName = result.repository.owner
         ? `${result.repository.owner}/${result.repository.name}`
         : result.repository.name;
-      if (
-        result.repository.owner === apolloName ||
-        result.repository.maintainer === apolloName
-      ) {
+      if (result.repository.maintainer === apolloName) {
         repoName += `&nbsp;&nbsp;${apolloIcon}`;
       }
       content += `Github: <a href="${result.repository.link}">${repoName}</a><br/>
@@ -159,10 +156,7 @@ Last Release: ${lastReleaseDate}<br/><br/>`;
       let coreLibraryName = result.coreLibrary.owner
         ? `${result.coreLibrary.owner}/${result.coreLibrary.name}`
         : result.coreLibrary.name;
-      if (
-        result.coreLibrary.owner === apolloName ||
-        result.coreLibrary.maintainer === apolloName
-      ) {
+      if (result.coreLibrary.maintainer === apolloName) {
         coreLibraryName += `&nbsp;&nbsp;${apolloIcon}`;
       }
       content += `Core Library: <a href="${result.coreLibrary.link}">${coreLibraryName}</a><br/>`;
@@ -172,10 +166,7 @@ Last Release: ${lastReleaseDate}<br/><br/>`;
       let fedLibraryName = result.federationlibrary.owner
         ? `${result.federationlibrary.owner}/${result.federationlibrary.name}`
         : result.federationlibrary.name;
-      if (
-        result.federationlibrary.owner === apolloName ||
-        result.federationlibrary.maintainer === apolloName
-      ) {
+      if (result.federationlibrary.maintainer === apolloName) {
         fedLibraryName += `&nbsp;&nbsp;${apolloIcon}`;
       }
       content += `Federation Library: <a href="${result.federationlibrary.link}">${fedLibraryName}</a><br/>`;