[IJ plugin] Don't suggest v4 migration until it is stable #5477
Conversation
✅ Deploy Preview for apollo-android-docs canceled.
|
| companion object { | ||
| const val apollo4LatestVersion = "4.0.0-beta.4" |
There was a problem hiding this comment.
You could use com.apollographql.apollo3.compiler.APOLLO_VERSION to have this match the published version automatically without having to bump this every time
| // Do not warn until 4.0 is stable (but keep enabled always in unit tests) | ||
| private val isEnabled = isUnitTestMode() || !ApolloV3ToV4MigrationProcessor.apollo4LatestVersion.contains('-') |
There was a problem hiding this comment.
This doesn't work for SNAPSHOTs like 4.0.1-SNAPSHOT which is OK if you maintain apollo4LatestVersion manually. Alternative would be using something like https://github.com/swiftzer/semver to do proper semver but that's more involved. Your call.
There was a problem hiding this comment.
I'll keep as-is to very slightly (debatable!) err on Bill's razor's side
There was a problem hiding this comment.
Sounds good 👍 . Also, who's Bill? 👀
There was a problem hiding this comment.
Our friend good ol' Bill Occam!
There was a problem hiding this comment.
Aahh William! Or is he known under 2 names? Which would be quite ironic 🙃
No description provided.