Added keyv 5 support for KeyvAdapter #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sroebert: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🦋 Changeset detectedLatest commit: 025b439 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sroebert
force-pushed
the
feature/keyv5-support
branch
from
8b8f7b4 to
817f195
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sroebert
force-pushed
the
feature/keyv5-support
branch
from
817f195 to
70f3c73
Compare
sroebert
force-pushed
the
feature/keyv5-support
branch
from
99280b5 to
7f71260
Compare
|
We'd also appreciate this to go through, whenever there's time! :) |
|
Here is also a team that is eagerly waiting this to go through! |
tninesling
approved these changes
Oct 18, 2024
glasser
reviewed
Oct 18, 2024
Added note about which version of Keyv is supported
Merged
tninesling
added a commit
to apollographql/apollo-server
that referenced
this pull request
Oct 23, 2024
The `@apollo/utils.keyvadapter` package was updated in apollographql/apollo-utils#461 to be compatible with Keyv v5. The primary change is that the `Keyv` constructor takes a store instead of a string. The constructor can be invoked in two ways: ``` // passed as first argument new Keyv(new KeyvRedis("redis://...")) // passed as store new Keyv({ store: new KeyvRedis("redis://...") }) ``` This updates the Redis examples in the documentation to match the new API. For simplicity, I've stuck to the first format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for keyv version 5, which fixes #457 and #459.