Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency lerna to v5 (version-0.x) #1889

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 25, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
lerna 4.0.0 -> 5.0.0 age adoption passing confidence

Release Notes

lerna/lerna

v5.0.0

Compare Source

Note: Version bump only for package lerna


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for apollo-federation-docs ready!

Name Link
🔨 Latest commit f20ebcb
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/628e7d489167090009800773
😎 Deploy Preview https://deploy-preview-1889--apollo-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@benweatherman
Copy link
Contributor

lerna@5 requires node 14.19.3 or higher. Since we currently still support node12, we'll have to hold off on this update.

@renovate
Copy link
Contributor Author

renovate bot commented May 27, 2022

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 5.x releases. However, if you upgrade to 5.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/version-0.x-lerna-5.x branch May 27, 2022 16:30
@trevor-scheer
Copy link
Member

@benweatherman I recommend fixing the version # in the renovate config. Future versions (i.e. 5.0.1) will open another PR and it'll continue.

Also feel free to ignore me, maybe we want to drop 12 and add 18 in v0.x soon?

@benweatherman
Copy link
Contributor

I can do that!

So we'll get PRs for 5.0.x but not 5.x? The bot above made me think it was gonna ignore all 5.x.x releases.

I'm also down to add node18 and drop node12 if we want. Is a [email protected] a "major" version bump so it's OK to drop node12 support going from 0.51.0 -> 0.52.0?

@trevor-scheer
Copy link
Member

Oh interesting, I misremembered the behavior (and didn't read the comment since I know everything, obv). Based on the comment, I'm completely wrong.

That made me curious how renovate behaves w.r.t. main vs. version-0.x, and it looks like it's as expected:
#468

And yeah! A 0.x bump allows us to do that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants