Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CSRF plugin #1006

Merged
merged 20 commits into from
May 13, 2022
Merged

feat: CSRF plugin #1006

merged 20 commits into from
May 13, 2022

Commits on May 10, 2022

  1. wip 

    Co-authored-by: Simon Sapin <[email protected]>
    @o0Ignition0o @SimonSapin
    o0Ignition0o and SimonSapin committed May 10, 2022
    Configuration menu
    Copy the full SHA
    482d1a7 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. wip: address review issues + add a bit of documentation. 

    todo: add more documentation + actually test the yml + update the cors docs tomorrow with simon
    @o0Ignition0o
    o0Ignition0o committed May 11, 2022
    Configuration menu
    Copy the full SHA
    331a5e1 View commit details
    Browse the repository at this point in the history

  2. compliance

    @o0Ignition0o
    o0Ignition0o committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a76847c View commit details
    Browse the repository at this point in the history

  3. remove noise from the custom-headers.router.yml file

    @o0Ignition0o
    o0Ignition0o committed May 11, 2022
    Configuration menu
    Copy the full SHA
    ff83523 View commit details
    Browse the repository at this point in the history

  4. recommended -> required + get closer to the fetch specification when … 

    …it comes to content type parsing
    @o0Ignition0o
    o0Ignition0o committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5f75844 View commit details
    Browse the repository at this point in the history

  5. wip, add a bunch of comments

    @o0Ignition0o
    o0Ignition0o committed May 11, 2022
    Configuration menu
    Copy the full SHA
    579eac0 View commit details
    Browse the repository at this point in the history

  6. more comments

    @o0Ignition0o
    o0Ignition0o committed May 11, 2022
    Configuration menu
    Copy the full SHA
    00cf251 View commit details
    Browse the repository at this point in the history

  7. update documentation

    @o0Ignition0o
    o0Ignition0o committed May 11, 2022
    Configuration menu
    Copy the full SHA
    00769c2 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. csrf tests: add helper functions for accepted/rejected requests

    @SimonSapin
    SimonSapin committed May 12, 2022
    Configuration menu
    Copy the full SHA
    03ca032 View commit details
    Browse the repository at this point in the history

  2. csrf: add a test for MIME type parsing

    @SimonSapin
    SimonSapin committed May 12, 2022
    Configuration menu
    Copy the full SHA
    d4afa38 View commit details
    Browse the repository at this point in the history

  3. wip, try to update docs

    @o0Ignition0o
    o0Ignition0o committed May 12, 2022
    Configuration menu
    Copy the full SHA
    19f96a2 View commit details
    Browse the repository at this point in the history

  4. rename csrf disabled option to unsafe_disabled + docs pass 1/n

    @o0Ignition0o
    o0Ignition0o committed May 12, 2022
    Configuration menu
    Copy the full SHA
    1759abb View commit details
    Browse the repository at this point in the history

  5. cors documentation part 2/n

    @o0Ignition0o
    o0Ignition0o committed May 12, 2022
    Configuration menu
    Copy the full SHA
    669b786 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. update documentation snapshot

    @o0Ignition0o
    o0Ignition0o committed May 13, 2022
    Configuration menu
    Copy the full SHA
    c4f101f View commit details
    Browse the repository at this point in the history

  2. revert cors documentation, as we will polish it in a followup pr

    @o0Ignition0o
    o0Ignition0o committed May 13, 2022
    Configuration menu
    Copy the full SHA
    ba41af3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into igni/csrf

    @o0Ignition0o
    o0Ignition0o committed May 13, 2022
    Configuration menu
    Copy the full SHA
    95c3526 View commit details
    Browse the repository at this point in the history

  4. Add three changelog entries: 

    Two breaking sections:
- one that explains the CORS default behavior changed
- one that explains the CSRF plugin will reject simple requests by default.

One feature section that explains a new CSRF plugin now exists.
    @o0Ignition0o
    o0Ignition0o committed May 13, 2022
    Configuration menu
    Copy the full SHA
    6622d4c View commit details
    Browse the repository at this point in the history

  5. order breaking section items by impact

    @o0Ignition0o
    o0Ignition0o committed May 13, 2022
    Configuration menu
    Copy the full SHA
    4d27490 View commit details
    Browse the repository at this point in the history

  6. hook the csrf plugin + send preflighted requests in our integration t… 

    …ests+ add an failed csrf check integration test
    @o0Ignition0o
    o0Ignition0o committed May 13, 2022
    Configuration menu
    Copy the full SHA
    a20105b View commit details
    Browse the repository at this point in the history

  7. revert CONTRIBUTING.md as it will be followed up on by @SimonSapin

    @o0Ignition0o
    o0Ignition0o committed May 13, 2022
    Configuration menu
    Copy the full SHA
    b35ed95 View commit details
    Browse the repository at this point in the history