-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add batch operations to pages #4684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroun
commented
Aug 21, 2024
async pageSetMenuSelection() { | ||
await this.getPages(); | ||
} | ||
created() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason for all this refactoring is to be more aligned with what we do in the piece manager.
* main: skipReplace for changeDocIds (#4694) API to expose locales (#4691) Pro 6387 images errors (#4670) CI test for A3 (#4690) Fix duplicate icons breaking the build (#4688) specify the rejected file extension in the error message (#4687) PRO-4659: new big upload middleware & corresponding client implementation (#4682)
haroun
commented
Aug 26, 2024
package.json
Outdated
@@ -69,7 +69,6 @@ | |||
"cors": "^2.8.5", | |||
"css-loader": "^5.2.4", | |||
"dayjs": "^1.9.8", | |||
"debounce-async": "0.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will conflicts with existing debounce work
boutell
previously approved these changes
Aug 28, 2024
This was referenced Sep 2, 2024
* Send checked types to the opened modals * Changelog
boutell
previously approved these changes
Sep 3, 2024
boutell
approved these changes
Sep 3, 2024
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Sep 16, 2024
* upstream/main: (77 commits) PRO-6578: auto import of inline images (apostrophecms#4723) Inline array improvements (apostrophecms#4671) take credit for the fix as well as the "change" (apostrophecms#4725) PRO-6576 fix default values for object fields in widgets and generally unify newInstance implementations (apostrophecms#4722) release 4.7.0 (apostrophecms#4717) allows to render widgets in published mode (for non localized with pu… (apostrophecms#4709) fix subfield imports (it was a bug in fetchRelationships: false) (apostrophecms#4715) Add replaces configuration for editor context menus (apostrophecms#4714) bump uploadfs dep (apostrophecms#4712) add batch operations to pages (apostrophecms#4684) PRO-6477 undhandled promise errors (apostrophecms#4700) fix slat order (apostrophecms#4710) make apostoggle accessible (apostrophecms#4708) Improve context menu positions (apostrophecms#4706) remove focus blockers in page relationship editor (apostrophecms#4702) Release 4.6.1 mergeback (apostrophecms#4703) remove z-index bump on area schema fields, boost menu index (apostrophecms#4699) Pro 6345 fix deprecated sass (apostrophecms#4640) Keep widget focused when menu is open (apostrophecms#4695) skipReplace for changeDocIds (apostrophecms#4694) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add batch operations to pages
What are the specific steps to test this change?
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: