PRO-6477 undhandled promise errors #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
requested changes
Aug 26, 2024
modules/@apostrophecms/image/ui/apos/components/AposMediaManager.vue
Outdated
Show resolved
Hide resolved
modules/@apostrophecms/image/ui/apos/components/AposMediaManager.vue
Outdated
Show resolved
Hide resolved
modules/@apostrophecms/image/ui/apos/components/AposMediaManager.vue
Outdated
Show resolved
Hide resolved
modules/@apostrophecms/image/ui/apos/components/AposMediaManager.vue
Outdated
Show resolved
Hide resolved
modules/@apostrophecms/piece-type/ui/apos/components/AposDocsManager.vue
Outdated
Show resolved
Hide resolved
boutell
requested changes
Aug 26, 2024
modules/@apostrophecms/piece-type/ui/apos/components/AposDocsManager.vue
Outdated
Show resolved
Hide resolved
modules/@apostrophecms/image/ui/apos/components/AposMediaManager.vue
Outdated
Show resolved
Hide resolved
* WIP on if not canceled approach * no need for finally block * Bugs and testing * fix the skipDelay * capture the timer * Finish replace debounce async --------- Co-authored-by: Miro Yovchev <[email protected]>
ValJed
previously requested changes
Aug 29, 2024
modules/@apostrophecms/piece-type/ui/apos/components/AposDocsManager.vue
Outdated
Show resolved
Hide resolved
boutell
approved these changes
Sep 3, 2024
haroun
added a commit
that referenced
this pull request
Sep 3, 2024
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Sep 16, 2024
* upstream/main: (77 commits) PRO-6578: auto import of inline images (apostrophecms#4723) Inline array improvements (apostrophecms#4671) take credit for the fix as well as the "change" (apostrophecms#4725) PRO-6576 fix default values for object fields in widgets and generally unify newInstance implementations (apostrophecms#4722) release 4.7.0 (apostrophecms#4717) allows to render widgets in published mode (for non localized with pu… (apostrophecms#4709) fix subfield imports (it was a bug in fetchRelationships: false) (apostrophecms#4715) Add replaces configuration for editor context menus (apostrophecms#4714) bump uploadfs dep (apostrophecms#4712) add batch operations to pages (apostrophecms#4684) PRO-6477 undhandled promise errors (apostrophecms#4700) fix slat order (apostrophecms#4710) make apostoggle accessible (apostrophecms#4708) Improve context menu positions (apostrophecms#4706) remove focus blockers in page relationship editor (apostrophecms#4702) Release 4.6.1 mergeback (apostrophecms#4703) remove z-index bump on area schema fields, boost menu index (apostrophecms#4699) Pro 6345 fix deprecated sass (apostrophecms#4640) Keep widget focused when menu is open (apostrophecms#4695) skipReplace for changeDocIds (apostrophecms#4694) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cancel debouncers, guard against unhandled promise rejections and potential memory leaks.
What are the specific steps to test this change?
No 'canceled' promise rejections. No UI regressions.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: