Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slat order on drag reorder #4710

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix slat order on drag reorder #4710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
### Fixes

* Adds an option to center the context menu arrow on the button icon. Sets this new option on some context menus in the admin UI.
* Fixes the update function of `AposSlatLists` so that elements are properly reordered on drag

## 4.6.1 (2024-08-26)

Expand Down
8 changes: 1 addition & 7 deletions modules/@apostrophecms/ui/ui/apos/components/AposSlatList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,7 @@ export default {
update({
oldIndex, newIndex
}) {
if (oldIndex !== newIndex) {
this.next = this.next.map((elem, index) => {
return index === oldIndex
? this.next[newIndex]
: (index === newIndex && this.next[oldIndex]) || elem;
});
}
this.next.splice(newIndex, 0, this.next.splice(oldIndex, 1)[0]);
},
engage(id) {
this.engaged = id;
Expand Down
Loading