set def field value for visible fields #4716
Conversation
| const field = schema.find(field => field.name === name); | ||
| const def = field && klona((field.def !== undefined) ? field.def : self.fieldTypes[field.type]?.def); | ||
| if (def) { | ||
| destination[field.name] = def; |
There was a problem hiding this comment.
This is not the place to do it. The front end should be honoring the defaults it already has and is already showing. Trying to force defaults at save time server side will be a regression to something we already agreed is bad: forcing the use of defaults when people intentionally clear fields.
There was a problem hiding this comment.
To be clear I am saying this a front end bug that needs a front end fix.
There was a problem hiding this comment.
To be clear: the front end should actually send the values it is initially displaying, whether those specific fields get touched or not. Not just those for fields the user moves the focus to.
There was a problem hiding this comment.
My guess is that the problem has something to do with the way the object field's v-model is implemented.
This reverts commit 105fe05.
ETLaurent
force-pushed
the
pro-6440-def
branch
from
b2a6b80
to
93e1d72
Compare
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: