Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds focus states for file input and media lib uploader #4729

Merged
merged 1 commit into from
Sep 18, 2024
Merged

adds focus states for file input and media lib uploader #4729

merged 1 commit into from
Sep 18, 2024

Conversation

stuartromanek
Copy link
Member

Summary

https://linear.app/apostrophecms/issue/PRO-4438/%5Baccessibility%5D-make-attachment-fields-visually-focused

  • Adds focus state to attachment input's file UI
  • Adds keyboard accessibility to trigger file selection from attachment input file UI
  • Refactors focus states for Media Library's uploader tile

What are the specific steps to test this change?

focus.mp4

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@linear Linear
Copy link

linear bot commented Sep 16, 2024

PRO-4438 [accessibility] Make attachment fields visually focused

ETLaurent
ETLaurent approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ETLaurent ETLaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuartromanek stuartromanek merged commit 4869e54 into main Sep 18, 2024
8 checks passed
@stuartromanek stuartromanek deleted the pro-4438/file-and-media-lib-focus branch September 18, 2024 16:10
haroun added a commit to haroun/apostrophe that referenced this pull request Sep 20, 2024
@haroun
Merge remote-tracking branch 'upstream/main'
96a2cfe 
* upstream/main:
  adds focus states for file input and media lib uploader (apostrophecms#4729)
  add <use> tag to DOMPurify allow list when sanitizing uploaded SVGS (apostrophecms#4727)
haroun added a commit that referenced this pull request Sep 23, 2024
@haroun
Merge branch 'main' into pro-6518-mobile-preview
5b8b7a3 
* main:
  hotfix 4.7.1 (#4733)
  PRO-6591: parked fields overrides (#4732)
  do not let a page become a child of itself (#4726)
  adds focus states for file input and media lib uploader (#4729)
  add <use> tag to DOMPurify allow list when sanitizing uploaded SVGS (#4727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ETLaurent ETLaurent ETLaurent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartromanek @ETLaurent