Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-6591: parked fields overrides #4732

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

myovchev
Copy link
Contributor

Summary

Ensure slug is not modified for parked pages when not configured in _defaults. Migrate any site having "home" parked doc with slug different than /,

What are the specific steps to test this change?

Slug of parked page can't be changed if not present in the _defaults configuration.

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

modules/@apostrophecms/page/index.js Show resolved Hide resolved
modules/@apostrophecms/page/index.js Outdated Show resolved Hide resolved
@myovchev myovchev merged commit 04cd8f5 into main Sep 20, 2024
8 checks passed
@myovchev myovchev deleted the pro-6591-parked-slug-overrides branch September 20, 2024 15:32
@myovchev myovchev changed the title PRO-6591: parked slug overrides PRO-6591: parked fields overrides Sep 20, 2024
haroun added a commit that referenced this pull request Sep 23, 2024
* main:
  hotfix 4.7.1 (#4733)
  PRO-6591: parked fields overrides (#4732)
  do not let a page become a child of itself (#4726)
  adds focus states for file input and media lib uploader (#4729)
  add <use> tag to DOMPurify allow list when sanitizing uploaded SVGS (#4727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants