Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-6660: modules order #4745

Merged
merged 7 commits into from
Oct 8, 2024
Merged

PRO-6660: modules order #4745

merged 7 commits into from
Oct 8, 2024

Conversation

myovchev
Copy link
Contributor

@myovchev myovchev commented Oct 5, 2024

Summary

Modules can now have a before: "module-name" property in their configuration to run (initialization) before another module. That works only for target modules that are initializable.

What are the specific steps to test this change?

// my-module/index.js
module.exports = {
  // will be initialized before the core image piece
  before: '@apostrophecms/image'
}

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link

linear bot commented Oct 5, 2024

@myovchev myovchev requested a review from boutell October 5, 2024 14:49
@myovchev myovchev changed the title Pro 6660: modules order PRO-6660: modules order Oct 5, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@myovchev myovchev requested a review from boutell October 7, 2024 15:22
index.js Outdated Show resolved Hide resolved
@myovchev myovchev requested a review from boutell October 8, 2024 14:25
@myovchev myovchev merged commit 1d6a91a into main Oct 8, 2024
8 checks passed
@myovchev myovchev deleted the PRO-6660-module-before branch October 8, 2024 17:14
haroun added a commit to haroun/apostrophe that referenced this pull request Oct 9, 2024
* upstream/main:
  Focus prioritized UI in on modal open (apostrophecms#4707)
  fix a rare race condition (apostrophecms#4755)
  prevent un-publishing singletons (apostrophecms#4739)
  PRO-6660: modules order (apostrophecms#4745)
  remove unused vue-template-compiler dependency (apostrophecms#4752)
  Fix pnpm: true (apostrophecms#4750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants