handle viewport values for breakpoint preview #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ETLaurent
commented
Oct 7, 2024
| @@ -17,6 +17,7 @@ body[data-breakpoint-preview-mode] { | |||
| } | |||
|
|
|||
| [data-apos-refreshable] { | |||
| position: relative; | |||
There was a problem hiding this comment.
absolute stuff are now correctly scoped
boutell
previously approved these changes
Oct 8, 2024
ETLaurent
changed the title
…ew-does-not-support-vhvw-units
…ew-does-not-support-vhvw-units
haroun
requested changes
Oct 15, 2024
There was a problem hiding this comment.
@ETLaurent Did you check also if vh units in vue files worked?
modules/@apostrophecms/asset/lib/webpack/postcss-replace-viewport-units-plugin.js
Outdated
Show resolved
Hide resolved
@haroun yes:
|
haroun
previously approved these changes
Oct 17, 2024
…ew-does-not-support-vhvw-units
haroun
approved these changes
Oct 17, 2024
ETLaurent
deleted the
pro-6637-mobile-preview-does-not-support-vhvw-units
branch
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Oct 18, 2024
* upstream/main: handle viewport values for breakpoint preview (apostrophecms#4748) Pro 6678 mobile preview dropdown (apostrophecms#4768) Fix menu focus (apostrophecms#4767) Update changelog for translations (apostrophecms#4766) [generate] Translate to German (apostrophecms#4759) [generate] Translate to Spanish (apostrophecms#4760) [generate] Translate to French (apostrophecms#4761) [generate] Translate to Italian (apostrophecms#4762) [generate] Translate to Portuguese (Brazil) (apostrophecms#4763) [generate] Translate to Slovak (apostrophecms#4764)
haroun
added a commit
that referenced
this pull request
Oct 22, 2024
* feature-vite: sass import warning (#4776) PRO-6657: Following values for dynamic choices (#4770) Tests HMR triggers, refactor to async due to upcoming EMS changes warnDev now prefixes in the expected way (#4746) Pro 6666 page move setting page as modified (#4771) handle viewport values for breakpoint preview (#4748) Pro 6678 mobile preview dropdown (#4768) Fix menu focus (#4767) Update changelog for translations (#4766)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use a custom
postcssplugin to duplicate declarations containingvhandvw(and only those) and change the units to container query compatibles ones (cqh,cqw) into a rule prefixed by:where(body[data-device-preview-mode])to take them into account only on breakpoint preview mode.Example: given I have the following CSS
I want to end up with the following CSS:
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: