Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily reverted PRO-6535 #4786

Closed
wants to merge 1 commit into from
Closed

temporarily reverted PRO-6535 #4786

wants to merge 1 commit into from

Conversation

boutell
Copy link
Member

@boutell boutell commented Oct 30, 2024

Summary

Temporary backing-out until we resolve the difference between intentionally leaving something out of a projection, and what was happening to the customer

What are the specific steps to test this change?

N/A

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@boutell boutell requested a review from BoDonkey October 30, 2024 19:49
Copy link

linear bot commented Oct 30, 2024

@ValJed
Copy link
Contributor

ValJed commented Oct 31, 2024

@boutell this PR should be closed I think since we roll backed the problematic part already.

@boutell
Copy link
Member Author

boutell commented Oct 31, 2024

LOL we never merged this? Glad you fixed it anyway!

@boutell boutell closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants