warn for page schema conflicts #4798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
requested changes
Nov 8, 2024
modules/@apostrophecms/page/index.js
Outdated
| for (const right of self.typeChoices) { | ||
| const diff = compareSchema(left, right); | ||
| if (diff.size) { | ||
| self.apos.util.warnDev(`The page type "${left.name}" has a conflict with "${right.name}" (${formatDiff(diff)})`); |
There was a problem hiding this comment.
"This may cause errors or other problems when an editor switches page types."
* main: changelog (#4802) fixes modals deep selectors (#4795) fix vue warnings (#4797) Pro 6694 breakpoint preview vite ready (#4789) Resolve yaml dependency conflicts (#4801) PRO-6775: External frontend support, docs cleanup (#4799) sort glob result (#4796) HMR condition argument and widget player fix (#4794) fix permission grid tooltip display (#4792) Fix extra bundle detection (#4791) release 4.9.0 (#4788) Pro 6535 revision (#4787)
boutell
requested changes
Nov 13, 2024
CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ did not actually use any noncompliant cookie names or values, so there was no vu | |||
| * It's possible now to target the HMR build when registering via `template.append` and `template.prepend`. Use `when: 'hmr:public'` or `when: 'hmr:apos'` that will be evaluated against the current asset `options.hmr` configuration. | |||
| * Adds asset module option `options.modulePreloadPolyfill` (default `true`) to allow disabling the polyfill preload for e.g. external front-ends. | |||
| * Adds `bundleMarkup` to the data sent to the external front-end, containing all markup for injecting Apostrophe UI in the front-end. | |||
| * Warns users when two page types shares the same field name, but has a different type. This may cause errors or other problems when an editor switches page types. | |||
There was a problem hiding this comment.
How about: "Warns users when two page types have the same field name, but a different field type"
To clarify what the issue is
boutell
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: