Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/select multiple #43

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Feature/select multiple #43

merged 6 commits into from
Oct 31, 2023

Conversation

haroun
Copy link
Contributor

@haroun haroun commented Oct 27, 2023

Summary

Add multiple and size option to select field widget

What are the specific steps to test this change?

  1. Add a select field widget to a form
  2. In the widget editor modal, set Allow multiple options to be selected to Yes
  3. Set the size to the value you want.
  4. Check the rendered template in Apostrophe admin UI and on the website

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@haroun haroun self-assigned this Oct 27, 2023
@haroun haroun marked this pull request as draft October 27, 2023 15:27
@haroun haroun marked this pull request as ready for review October 30, 2023 15:31
@haroun haroun requested a review from boutell October 30, 2023 15:31
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please put it behind a module-level option that defaults to false. The user experience of "out of the box" HTML multiple select is not good and we don't have time to pursue designing a better experience and doing progressive enhancement in this cycle, per Alex. I know that for the project you have in mind this is less of an issue because the UI is rebuilt in Vue anyway.

@haroun haroun requested a review from boutell October 31, 2023 12:49
@haroun haroun merged commit 53ee90e into main Oct 31, 2023
6 checks passed
@haroun haroun deleted the feature/select-multiple branch October 31, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants