chore: disable debugger for wda #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dan-Maor does this change make sense for you? |
mykola-mokhnach
approved these changes
Oct 25, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
## [5.11.6](v5.11.5...v5.11.6) (2023-10-25) ### Miscellaneous Chores * disable debugger for wda ([#768](#768)) ([e2f4405](e2f4405))
|
🎉 This PR is included in version 5.11.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable "Debug Executable"
This would slightly improve the launching performance via xcodebuild by skipping the debug server connection. 4k tv will have more improvement I guess since it is network-connected, and available via xcodebuild for now. As down-side, we should enable this checkbox to enable breakpoints for our development (if needed). Except for it, this uncheck won't break existing behavior as WDA functionality.
What do you think to disable it by default...?
As a downside, we need to enable it when we manually debug WDA