Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration #943

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

style: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration #943

wants to merge 2 commits into from
+6 −38

Conversation

aluedeke
Copy link

@aluedeke aluedeke commented Oct 7, 2024

to be able to use WDA lib as a lib this cleanup helps

  • FBBaseActionsParser isn't used in the xcode project
  • imports in FBConfiguration should be part of the impl not the header, so an reexport isn't needed

@aluedeke aluedeke changed the title remove unused FBBaseActionsParser and cleanup imports in FBConfiguration style: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration Oct 7, 2024
@mykola-mokhnach
Copy link

Please change the PR type to chore: to trigger automatic version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aluedeke @mykola-mokhnach