Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error by xmldom #437

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix: type error by xmldom #437

merged 2 commits into from
Sep 16, 2024

Conversation

KazuCocoa
Copy link
Member

lib/defaults-utils.js:15:14 - error TS2304: Cannot find name 'Node'.

15  * @returns {Node|string} Either string or raw node representation of
                ~~~~

lib/defaults-utils.js:28:7 - error TS18047: 'xmlDoc.documentElement' is possibly 'null'.

28       xmlDoc.documentElement.appendChild(keyEl);
         ~~~~~~~~~~~~~~~~~~~~~~

lib/defaults-utils.js:31:7 - error TS18047: 'xmlDoc.documentElement' is possibly 'null'.

31       xmlDoc.documentElement.appendChild(subValueEl);
         ~~~~~~~~~~~~~~~~~~~~~~

lib/defaults-utils.js:38:7 - error TS18047: 'xmlDoc.documentElement' is possibly 'null'.

38       xmlDoc.documentElement.appendChild(subValueEl);
         ~~~~~~~~~~~~~~~~~~~~~~

lib/defaults-utils.js:49:5 - error TS18047: 'xmlDoc.documentElement' is possibly 'null'.

49     xmlDoc.documentElement.appendChild(valueTextEl);
       ~~~~~~~~~~~~~~~~~~~~~~

lib/defaults-utils.js:58:45 - error TS2345: Argument of type 'Element | null' is not assignable to parameter of type 'Node'.
  Type 'null' is not assignable to type 'Node'.

58     ? new XMLSerializer().serializeToString(xmlDoc.documentElement)
                                               ~~~~~~~~~~~~~~~~~~~~~~


Found 6 errors.

lib/defaults-utils.js Outdated Show resolved Hide resolved
@KazuCocoa KazuCocoa marked this pull request as ready for review September 14, 2024 03:28
@KazuCocoa KazuCocoa merged commit 4d85282 into master Sep 16, 2024
12 checks passed
@KazuCocoa KazuCocoa deleted the fix-type branch September 16, 2024 03:18
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
## [6.1.12](v6.1.11...v6.1.12) (2024-09-16)

### Bug Fixes

* type error by xmldom ([#437](#437)) ([4d85282](4d85282))
Copy link

🎉 This PR is included in version 6.1.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants